Skip to content

Conversation

lottieo
Copy link
Contributor

@lottieo lottieo commented Oct 15, 2025

Description

Enter a description of the changes here

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage

Agile board tracking

connect to #563

@lottieo lottieo requested a review from joelvdavies October 15, 2025 16:02
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.20%. Comparing base (f4313f2) to head (18a5d10).

Files with missing lines Patch % Lines
...ntory_management_system_api/schemas/system_type.py 0.00% 2 Missing ⚠️

❌ Your patch check has failed because the patch coverage (50.00%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #631      +/-   ##
===========================================
- Coverage    97.29%   97.20%   -0.10%     
===========================================
  Files           57       57              
  Lines         1998     2002       +4     
===========================================
+ Hits          1944     1946       +2     
- Misses          54       56       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@joelvdavies joelvdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor comments.

@lottieo lottieo requested a review from joelvdavies October 20, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants