-
Notifications
You must be signed in to change notification settings - Fork 0
Use MongoDB indexing to prevent duplicate names #646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
VKTB
wants to merge
11
commits into
implement-authorisation-for-units-#609
Choose a base branch
from
duplicate-name-prevention-using-indexing-#512
base: implement-authorisation-for-units-#609
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Use MongoDB indexing to prevent duplicate names #646
VKTB
wants to merge
11
commits into
implement-authorisation-for-units-#609
from
duplicate-name-prevention-using-indexing-#512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## implement-authorisation-for-units-#609 #646 +/- ##
==========================================================================
- Coverage 97.27% 97.24% -0.03%
==========================================================================
Files 58 58
Lines 2016 1996 -20
==========================================================================
- Hits 1961 1941 -20
Misses 55 55 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similar to ral-facilities/object-storage-api#154. It replaces the manual duplicate name checks. Also ensures we shouldn't have race conditions due to concurrency which would otherwise allow some catalogue categories/manufacturers/systems/units/usage statuses with duplicate names from getting added to the database. This should not require any changes to your local MongoDB instance, calling
docker compose upshould be sufficient to get the indexes setup for the tests and development.The README(s) and the
mongodb-entrypoint.shscript will need updating in thedocker-ims.Notes
codeand sometimesparent_id(both ascending) - This has the side effect of changing the order results are returned when filtering byparent_idto be code ascending whereas before they were typically in creation order (although MongoDB doesn't guarantee the order unless you use sort explicitly anyway).Testing instructions
Agile board tracking
closes #512