-
Notifications
You must be signed in to change notification settings - Fork 0
Refresh logic for manufacturers landing page #1460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: future
Are you sure you want to change the base?
Conversation
❌ File not in storage
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great so far! Just a couple small comments :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you try move the refresh button to have space between the other 2 buttons. It should appear on the far right of the page. Play around with the grids and different flex options
Refresh | ||
</Button> | ||
<Typography data-testid="refresh-timestamp" textAlign={'center'} variant="body1"> | ||
{formatDateTimeStrings(editRefreshDate.toISOString(), true)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final comment! Just makes it a tad clearer what the actual timestamp is for
{formatDateTimeStrings(editRefreshDate.toISOString(), true)} | |
Last refreshed at: {formatDateTimeStrings(editRefreshDate.toISOString(), true)} |
Description
Refresh button that gives time of last refresh and causes the page to refresh.
Testing instructions
Add a set up instructions describing how the reviewer should test the code
Agile board tracking
closes #1439