Implement authorisation for bypassing rules #1523 #1529

MatteoGuarnaccia5 · 2025-10-06T11:07:28Z

Description

Enter a description of the changes here

Testing instructions

Add a set up instructions describing how the reviewer should test the code

Review code
Check Actions build
Review changes to test coverage
{more steps here}

Agile board tracking

connect to {issue number}

codecov · 2025-10-06T11:08:40Z

❌ 2 Tests Failed:

Tests completed	Failed	Passed	Skipped
826	2	824	1

View the full list of 2 ❄️ flaky test(s)

src/items/itemsTable.component.test.tsx > Items Table > renders the dense table correctly

Flake rate in main: 8.70% (Passed 21 times, Failed 2 times)

Stack Traces | 0.964s run time

Error: Snapshot `Items Table > renders the dense table correctly 1` mismatched

- Expected
+ Received

@@ -204,16 +204,16 @@
                                  </svg>
                                </button>
                              </span>
                            </div>
                            <input
-                             aria-describedby=":r2ql:-helper-text"
+                             aria-describedby=":r2mu:-helper-text"
                              aria-invalid="false"
                              aria-label="Filter by Serial Number"
                              autocomplete="off"
                              class="MuiInputBase-input MuiInput-input MuiInputBase-inputAdornedStart MuiInputBase-inputAdornedEnd css-110vr2a-MuiInputBase-input-MuiInput-input"
-                             id=":r2ql:"
+                             id=":r2mu:"
                              placeholder="Filter by Serial Number"
                              title="Filter by Serial Number"
                              type="text"
                              value=""
                            />
@@ -247,11 +247,11 @@
                              </span>
                            </div>
                          </div>
                          <p
                            class="MuiFormHelperText-root MuiFormHelperText-sizeMedium css-v98l45-MuiFormHelperText-root"
-                           id=":r2ql:-helper-text"
+                           id=":r2mu:-helper-text"
                          >
                            <label>
                              Filter Mode: Fuzzy
                            </label>
                          </p>
@@ -361,15 +361,15 @@
                          >
                            <div
                              class="MuiInputBase-root MuiInput-root MuiInput-underline MuiInputBase-colorPrimary MuiInputBase-fullWidth MuiInputBase-formControl MuiInputBase-adornedEnd css-6h9cc6-MuiInputBase-root-MuiInput-root"
                            >
                              <input
-                               aria-describedby=":r2qu:-helper-text"
+                               aria-describedby=":r2n7:-helper-text"
                                aria-invalid="false"
                                autocomplete="off"
                                class="MuiInputBase-input MuiInput-input MuiInputBase-inputAdornedEnd css-1yrc8ca-MuiInputBase-input-MuiInput-input"
-                               id=":r2qu:"
+                               id=":r2n7:"
                                inputmode="text"
                                placeholder="Min"
                                type="text"
                                value=""
                              />
@@ -396,11 +396,11 @@
                                </button>
                              </div>
                            </div>
                            <p
                              class="MuiFormHelperText-root MuiFormHelperText-sizeMedium css-18y2hez-MuiFormHelperText-root"
-                             id=":r2qu:-helper-text"
+                             id=":r2n7:-helper-text"
                            >
                              <label>
                                Filter Mode: Between Inclusive
                              </label>
                            </p>
@@ -413,11 +413,11 @@
                            >
                              <input
                                aria-invalid="false"
                                autocomplete="off"
                                class="MuiInputBase-input MuiInput-input MuiInputBase-inputAdornedEnd css-1yrc8ca-MuiInputBase-input-MuiInput-input"
-                               id=":r2r1:"
+                               id=":r2na:"
                                inputmode="text"
                                placeholder="Max"
                                type="text"
                                value=""
                              />
@@ -551,15 +551,15 @@
                          >
                            <div
                              class="MuiInputBase-root MuiInput-root MuiInput-underline MuiInputBase-colorPrimary MuiInputBase-fullWidth MuiInputBase-formControl MuiInputBase-adornedEnd css-6h9cc6-MuiInputBase-root-MuiInput-root"
                            >
                              <input
-                               aria-describedby=":r2r8:-helper-text"
+                               aria-describedby=":r2nh:-helper-text"
                                aria-invalid="false"
                                autocomplete="off"
                                class="MuiInputBase-input MuiInput-input MuiInputBase-inputAdornedEnd css-1yrc8ca-MuiInputBase-input-MuiInput-input"
-                               id=":r2r8:"
+                               id=":r2nh:"
                                inputmode="text"
                                placeholder="Min"
                                type="text"
                                value=""
                              />
@@ -586,11 +586,11 @@
                                </button>
                              </div>
                            </div>
                            <p
                              class="MuiFormHelperText-root MuiFormHelperText-sizeMedium css-18y2hez-MuiFormHelperText-root"
-                             id=":r2r8:-helper-text"
+                             id=":r2nh:-helper-text"
                            >
                              <label>
                                Filter Mode: Between Inclusive
                              </label>
                            </p>
@@ -603,11 +603,11 @@
                            >
                              <input
                                aria-invalid="false"
                                autocomplete="off"
                                class="MuiInputBase-input MuiInput-input MuiInputBase-inputAdornedEnd css-1yrc8ca-MuiInputBase-input-MuiInput-input"
-                               id=":r2rb:"
+                               id=":r2nk:"
                                inputmode="text"
                                placeholder="Max"
                                type="text"
                                value=""
                              />
@@ -741,15 +741,15 @@
                          >
                            <div
                              class="MuiInputBase-root MuiInput-root MuiInput-underline MuiInputBase-colorPrimary MuiInputBase-fullWidth MuiInputBase-formControl MuiInputBase-adornedEnd css-6h9cc6-MuiInputBase-root-MuiInput-root"
                            >
                              <input
-                               aria-describedby=":r2ri:-helper-text"
+                               aria-describedby=":r2nr:-helper-text"
                                aria-invalid="false"
                                autocomplete="off"
                                class="MuiInputBase-input MuiInput-input MuiInputBase-inputAdornedEnd css-1yrc8ca-MuiInputBase-input-MuiInput-input"
-                               id=":r2ri:"
+                               id=":r2nr:"
                                inputmode="text"
                                placeholder="Min"
                                type="text"
                                value=""
                              />
@@ -776,11 +776,11 @@
                                </button>
                              </div>
                            </div>
                            <p
                              class="MuiFormHelperText-root MuiFormHelperText-sizeMedium css-18y2hez-MuiFormHelperText-root"
-                             id=":r2ri:-helper-text"
+                             id=":r2nr:-helper-text"
                            >
                              <label>
                                Filter Mode: Between Inclusive
                              </label>
                            </p>
@@ -793,11 +793,11 @@
                            >
                              <input
                                aria-invalid="false"
                                autocomplete="off"
                                class="MuiInputBase-input MuiInput-input MuiInputBase-inputAdornedEnd css-1yrc8ca-MuiInputBase-input-MuiInput-input"
-                               id=":r2rl:"
+                               id=":r2nu:"
                                inputmode="text"
                                placeholder="Max"
                                type="text"
                                value=""
                              />
@@ -931,15 +931,15 @@
                          >
                            <div
                              class="MuiInputBase-root MuiInput-root MuiInput-underline MuiInputBase-colorPrimary MuiInputBase-fullWidth MuiInputBase-formControl MuiInputBase-adornedEnd css-6h9cc6-MuiInputBase-root-MuiInput-root"
                            >
                              <input
-                               aria-describedby=":r2rs:-helper-text"
+                               aria-describedby=":r2o5:-helper-text"
                                aria-invalid="false"
                                autocomplete="off"
                                class="MuiInputBase-input MuiInput-input MuiInputBase-inputAdornedEnd css-1yrc8ca-MuiInputBase-input-MuiInput-input"
-                               id=":r2rs:"
+                               id=":r2o5:"
                                inputmode="text"
                                placeholder="Min"
                                type="text"
                                value=""
                              />
@@ -966,11 +966,11 @@
                                </button>
                              </div>
                            </div>
                            <p
                              class="MuiFormHelperText-root MuiFormHelperText-sizeMedium css-18y2hez-MuiFormHelperText-root"
-                             id=":r2rs:-helper-text"
+                             id=":r2o5:-helper-text"
                            >
                              <label>
                                Filter Mode: Between Inclusive
                              </label>
                            </p>
@@ -983,11 +983,11 @@
                            >
                              <input
                                aria-invalid="false"
                                autocomplete="off"
                                class="MuiInputBase-input MuiInput-input MuiInputBase-inputAdornedEnd css-1yrc8ca-MuiInputBase-input-MuiInput-input"
-                               id=":r2rv:"
+                               id=":r2o8:"
                                inputmode="text"
                                placeholder="Max"
                                type="text"
                                value=""
                              />
@@ -1121,13 +1121,13 @@
                          >
                            <div
                              aria-expanded="false"
                              aria-haspopup="listbox"
                              aria-label="Filter by Is Defective"
-                             aria-labelledby=":r2s6:"
+                             aria-labelledby=":r2of:"
                              class="MuiSelect-select MuiSelect-standard MuiInputBase-input MuiInput-input MuiInputBase-inputAdornedEnd css-10y8whu-MuiSelect-select-MuiInputBase-input-MuiInput-input"
-                             id=":r2s6:"
+                             id=":r2of:"
                              role="combobox"
                              tabindex="0"
                            >
                              <div
                                class="MuiBox-root css-1tzeee1"
@@ -1774,11 +1774,11 @@
                <div
                  class="MuiBox-root css-exd1zr"
                >
                  <label
                    class="MuiFormLabel-root MuiInputLabel-root MuiInputLabel-animated MuiFormLabel-colorPrimary MuiInputLabel-root MuiInputLabel-animated css-10j3yc8-MuiFormLabel-root-MuiInputLabel-root"
-                   for="mrt-rows-per-page-:r2qe:"
+                   for="mrt-rows-per-page-:r2mn:"
                  >
                    Rows per page
                  </label>
                  <div
                    class="MuiInputBase-root MuiInput-root MuiInputBase-colorPrimary MuiSelect-root css-1y2ya84-MuiInputBase-root-MuiInput-root-MuiSelect-root"
@@ -1795,11 +1795,11 @@
                    </div>
                    <input
                      aria-hidden="true"
                      aria-invalid="false"
                      class="MuiSelect-nativeInput css-j0riat-MuiSelect-nativeInput"
-                     id="mrt-rows-per-page-:r2qe:"
+                     id="mrt-rows-per-page-:r2mn:"
                      tabindex="-1"
                      value="5"
                    />
                    <svg
                      aria-hidden="true"

 ❯ src/items/itemsTable.component.test.tsx:509:31

src/systems/systemItemsTable.component.test.tsx > SystemItemsTable > renders correctly

Flake rate in main: 100.00% (Passed 0 times, Failed 1 times)

Stack Traces | 5.01s run time

Error: Snapshot `SystemItemsTable > renders correctly 1` mismatched

- Expected
+ Received

@@ -1202,15 +1202,15 @@
                        >
                          <div
                            class="MuiInputBase-root MuiInput-root MuiInput-underline MuiInputBase-colorPrimary MuiInputBase-fullWidth MuiInputBase-formControl MuiInputBase-adornedEnd css-6h9cc6-MuiInputBase-root-MuiInput-root"
                          >
                            <input
-                             aria-describedby=":r59:-helper-text"
+                             aria-describedby=":r5b:-helper-text"
                              aria-invalid="false"
                              autocomplete="off"
                              class="MuiInputBase-input MuiInput-input MuiInputBase-inputAdornedEnd css-1yrc8ca-MuiInputBase-input-MuiInput-input"
-                             id=":r59:"
+                             id=":r5b:"
                              inputmode="text"
                              placeholder="Min"
                              type="text"
                              value=""
                            />
@@ -1237,11 +1237,11 @@
                              </button>
                            </div>
                          </div>
                          <p
                            class="MuiFormHelperText-root MuiFormHelperText-sizeMedium css-18y2hez-MuiFormHelperText-root"
-                           id=":r59:-helper-text"
+                           id=":r5b:-helper-text"
                          >
                            <label>
                              Filter Mode: Between Inclusive
                            </label>
                          </p>
@@ -1254,11 +1254,11 @@
                          >
                            <input
                              aria-invalid="false"
                              autocomplete="off"
                              class="MuiInputBase-input MuiInput-input MuiInputBase-inputAdornedEnd css-1yrc8ca-MuiInputBase-input-MuiInput-input"
-                             id=":r5c:"
+                             id=":r5e:"
                              inputmode="text"
                              placeholder="Max"
                              type="text"
                              value=""
                            />

 ❯ src/systems/systemItemsTable.component.test.tsx:82:31

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

…g items between systems

…o implement-authorisation-for-bypassing-rules-#1523

functionality for add/edit/delete/move items as admin

a55f2b2

MatteoGuarnaccia5 changed the base branch from develop to refactor-admin-page-to-utilise-authorisation-#1472 October 6, 2025 11:07

MatteoGuarnaccia5 added 11 commits October 7, 2025 12:29

added unit tests for item create/edit/delete

4b48a4a

added functionality to allow admins to select usage status when movin…

a79dc78

…g items between systems

change admin warnings to tooltips in dialogs

e785da0

changed isUserAuthorised variable to isAdminUser

d6ec196

added and refactored unit tests

07ae599

update snapshot

f58ec51

added e2e tests

336f513

removed it.only

56b1713

Merge branch 'refactor-admin-page-to-utilise-authorisation-#1472' int…

0e6aa22

…o implement-authorisation-for-bypassing-rules-#1523

update tokens to reflect changes in ldap-jwt-auth

b743e4d

update snapshots

08423d8

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Implement authorisation for bypassing rules #1523 #1529

Implement authorisation for bypassing rules #1523 #1529

MatteoGuarnaccia5 commented Oct 6, 2025

Uh oh!

codecov bot commented Oct 6, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Implement authorisation for bypassing rules #1523 #1529

Are you sure you want to change the base?

Implement authorisation for bypassing rules #1523 #1529

Conversation

MatteoGuarnaccia5 commented Oct 6, 2025

Description

Testing instructions

Agile board tracking

Uh oh!

codecov bot commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ 2 Tests Failed:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

codecov bot commented Oct 6, 2025 •

edited

Loading