Skip to content

Conversation

@MatteoGuarnaccia5
Copy link
Contributor

@MatteoGuarnaccia5 MatteoGuarnaccia5 commented Oct 28, 2025

Description

Fix for item dialog useForm due to upgrade to react-hook-form v7.62.0 (see #1391 )

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage

@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

❌ Patch coverage is 91.48936% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.66%. Comparing base (f07e5fb) to head (ac9683f).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/items/itemDialog.component.tsx 91.30% 4 Missing ⚠️
Additional details and impacted files
@@                          Coverage Diff                          @@
##           react-hook-form-system-dialog-fix    #1553      +/-   ##
=====================================================================
- Coverage                              98.66%   98.66%   -0.01%     
=====================================================================
  Files                                    106      106              
  Lines                                  21085    21094       +9     
  Branches                                3391     2440     -951     
=====================================================================
+ Hits                                   20804    20812       +8     
- Misses                                   276      281       +5     
+ Partials                                   5        1       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MatteoGuarnaccia5 MatteoGuarnaccia5 changed the title refactored useForm and dialog in item dialog refactored useForm for item dialog Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants