Bump node version to v22 on CI to match project & docker #1244 #1559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1559 +/- ##
=========================================
Coverage 98.81% 98.81%
=========================================
Files 110 110
Lines 21585 21597 +12
Branches 2465 3445 +980
=========================================
+ Hits 21329 21341 +12
+ Misses 255 251 -4
- Partials 1 5 +4 ☔ View full report in Codecov by Sentry. |
joelvdavies
force-pushed
the
bump-node-to-v22-on-ci-#1244
branch
19 times, most recently
from
53e95cb to
c165c45
Compare
joelvdavies
force-pushed
the
bump-node-to-v22-on-ci-#1244
branch
from
c165c45 to
75dd8c2
Compare
joelvdavies
force-pushed
the
bump-node-to-v22-on-ci-#1244
branch
2 times, most recently
from
7abf94e to
2a8e94f
Compare
joelvdavies
force-pushed
the
bump-node-to-v22-on-ci-#1244
branch
from
2a8e94f to
6e932ca
Compare
joelvdavies
force-pushed
the
bump-node-to-v22-on-ci-#1244
branch
2 times, most recently
from
68f0bc1 to
621db99
Compare
joelvdavies
force-pushed
the
bump-node-to-v22-on-ci-#1244
branch
from
621db99 to
32e84e8
Compare
Contributor
Author
|
4th time in a row 🥳. No idea how considering I didnt change anything to avoid the document is not found errors. |
joshdimanteto
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Just to close an issue I made a while ago. The latest version is v24, and rennovate is correctly fixing this in that PR (#1558) so no idea how it became out of sync. But due to nvm being a bit broken for me, (I cant seem to force the default version and it just resets each time unless I uninstall v22, so may want to fix that/upgrade scigateway too) and because there are some breaking changes looking at the CI, I thought it best to leave it for the moment. Its also only been LTS for 2 days.
I did update to the latest v22 version and fixed the specific version on the CI (I am hoping renovate will keep doing that) so we can even more closely match versions used on the CI and docker images.
This has undone the gains from #1554 unfortunately. CI will fail due to Harbor being down until at least Monday.
Testing instructions
Add a set up instructions describing how the reviewer should test the code
Agile board tracking
Closes #1244