-
Notifications
You must be signed in to change notification settings - Fork 0
Implement base authorisation #1472 #1596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MatteoGuarnaccia5
wants to merge
49
commits into
develop
Choose a base branch
from
implement-base-authorisation-#1472
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1596 +/- ##
===========================================
- Coverage 98.82% 98.82% -0.01%
===========================================
Files 111 114 +3
Lines 21769 21920 +151
Branches 2501 2512 +11
===========================================
+ Hits 21514 21663 +149
- Misses 254 256 +2
Partials 1 1 ☔ View full report in Codecov by Sentry. |
joelvdavies
previously approved these changes
Nov 13, 2025
joelvdavies
approved these changes
Nov 13, 2025
joshdimanteto
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based off original issue #1472, admin functionality is added via
parseToken.ts, which will return if the current user's token has any role that is also a part of the configuredprivilegedRoles. If the user does have a privileged status, they will be able to edit/create units/usage statuses (completed in this PR), bypass rules (to be done #1523 ), and an alert with their role will appear in the top right of the website.The
/adminroute, along with component and filenames have been renamed to be/settings,SettingsetcPlease note:
This PR is dependent on ral-facilities/ldap-jwt-auth#271 in ldap-jwt-auth, and should be merged in conjunction with it, to avoid breaking changes.
This PR adds a new key/value pair to the
inventory-management-system-settings.json, this change should also be made in scigateway for production.Testing instructions
Agile board tracking
connect to #1472