Skip to content

Conversation

@joshdimanteto
Copy link
Contributor

Description

move spares to be defined in an provider as it is used in multiple different places as config

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage

Agile board tracking

closes #1595

@joshdimanteto joshdimanteto force-pushed the create-api-config-provider-#1595 branch from 97aad1f to 8ded06d Compare November 12, 2025 17:01
@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.82%. Comparing base (1b6c04d) to head (ae65126).
⚠️ Report is 2 commits behind head on develop.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop    #1598    +/-   ##
=========================================
  Coverage    98.82%   98.82%            
=========================================
  Files          110      111     +1     
  Lines        21724    21769    +45     
  Branches      2492     3487   +995     
=========================================
+ Hits         21468    21514    +46     
+ Misses         255      250     -5     
- Partials         1        5     +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshdimanteto joshdimanteto force-pushed the create-api-config-provider-#1595 branch from 8ded06d to 55123b7 Compare November 12, 2025 17:13
@joshdimanteto joshdimanteto force-pushed the create-api-config-provider-#1595 branch from 55123b7 to ae65126 Compare November 12, 2025 17:31
@joshdimanteto joshdimanteto marked this pull request as ready for review November 12, 2025 17:55
Copy link
Contributor

@joelvdavies joelvdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked well just a single comment.

@joshdimanteto joshdimanteto merged commit 678342f into develop Nov 13, 2025
10 of 13 checks passed
@joshdimanteto joshdimanteto deleted the create-api-config-provider-#1595 branch November 13, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create a provider for API config

3 participants