Skip to content

Conversation

@joshdimanteto
Copy link
Contributor

Description

add alert banner to rules

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage
  • {more steps here}

Agile board tracking

closes #1603

@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

❌ Patch coverage is 96.73913% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.82%. Comparing base (ab44fe6) to head (0fdad8f).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/admin/rules/rules.component.tsx 95.83% 3 Missing ⚠️
Additional details and impacted files
@@                             Coverage Diff                              @@
##           add-alert-banner-for-systems-types-#1602    #1606      +/-   ##
============================================================================
- Coverage                                     98.83%   98.82%   -0.02%     
============================================================================
  Files                                           112      112              
  Lines                                         21843    21900      +57     
  Branches                                       2510     2515       +5     
============================================================================
+ Hits                                          21588    21642      +54     
- Misses                                          254      257       +3     
  Partials                                          1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The columnfilterfuncs where not being reset and this caused weirdness
when switching
@joshdimanteto joshdimanteto linked an issue Nov 13, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

implement alert banner for the rules table

2 participants