Skip to content

Conversation

@joshdimanteto
Copy link
Contributor

Description

add logic to disable the banner if it is system_ids are equal i.e the item hasn't moved
removes waits in cypress testing

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage
  • {more steps here}

Agile board tracking

closes #1608

@joshdimanteto joshdimanteto force-pushed the add-alert-banner-for-system-items-dialog-#1608 branch from 9a01a63 to f5151e4 Compare November 13, 2025 18:30
@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.82%. Comparing base (97082de) to head (00440d1).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@                            Coverage Diff                            @@
##           add-alert-banner-for-items-dialog-#1607    #1610    +/-   ##
=========================================================================
  Coverage                                    98.82%   98.82%            
=========================================================================
  Files                                          112      112            
  Lines                                        21918    21934    +16     
  Branches                                      2524     3520   +996     
=========================================================================
+ Hits                                         21660    21676    +16     
+ Misses                                         257      253     -4     
- Partials                                         1        5     +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshdimanteto joshdimanteto force-pushed the add-alert-banner-for-system-items-dialog-#1608 branch from f5151e4 to 87fb0ae Compare November 14, 2025 10:15
@joshdimanteto joshdimanteto linked an issue Nov 14, 2025 that may be closed by this pull request
@joshdimanteto joshdimanteto force-pushed the add-alert-banner-for-system-items-dialog-#1608 branch from 87fb0ae to 00440d1 Compare November 14, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add alert banner to system items dialog

2 participants