Skip to content

Conversation

VKTB
Copy link
Contributor

@VKTB VKTB commented Oct 14, 2025

Description

Updates the tests after the OIDC changes. See #272 (comment) and #271 (comment).

Testing instructions

  • Review code
  • Check Actions build
  • Review changes to test coverage

Agile board tracking

closes #278

@VKTB VKTB changed the base branch from develop to add-support-for-admin-user-types-#246 October 14, 2025 13:21
@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2025

Codecov Report

❌ Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 85.53%. Comparing base (ac8a2df) to head (48c730a).

Files with missing lines Patch % Lines
ldap_jwt_auth/auth/authentication.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #283       +/-   ##
============================================
+ Coverage    74.69%   85.53%   +10.84%     
============================================
  Files           10       10               
  Lines          328      325        -3     
============================================
+ Hits           245      278       +33     
+ Misses          83       47       -36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@VKTB VKTB force-pushed the update-tests-after-oidc-changes-#278 branch from 9473628 to c67f377 Compare October 14, 2025 14:40
Base automatically changed from add-support-for-admin-user-types-#246 to develop October 17, 2025 13:51
@VKTB VKTB marked this pull request as ready for review October 17, 2025 14:18
Comment on lines +77 to +83
access_token = (
"eyJhbGciOiJSUzI1NiIsInR5cCI6IkpXVCJ9.eyJ1c2VybmFtZSI6InVzZXIxMjMiLCJleHAiOi02MjEzNTU5NjgwMH0.hMFgx83bidY-r"
"2SVlp2fnKwzD-SaCbzfD054A_lRsEOyYYtSB52kBvnkp_oagYelXhEczfGGsfWzV_JkgalM-449KI99qImlab45ANyhriHoaDhMvs9ve_0"
"TwPfD34zU3Y2PkcrgZ7lbYDqMArVOBDsAiO12ejYA7CAMjUBKgoXPIzMqup1Ah8Mzg0F5Gu2iUpoDfCyIt86KjAEiYk-CDm6w73b28BOaW"
"axk87tXUYXE64KIWNkh99iXgYEDYvfSmvWdu6TCHtVmNzJ_Tb1egVHb-hO-3G62mnyHJ2x6p_k7Wq44JuGyC0SrRHWp-jZsubLvi_ikBDm"
"6qgZ8mKcJxA"
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a double check that this token has been created with the admin changes implemented, so that it follows the ones now in the mock data.

@@ -0,0 +1,157 @@
"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we plan on having e2e tests for LDAPLogin as well in a different PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update tests after OIDC changes

3 participants