Skip to content

Conversation

@joelvdavies
Copy link
Contributor

@joelvdavies joelvdavies commented Jun 16, 2025

Description

Applying some changes from ral-facilities/inventory-management-system-api#517 here.

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage

Agile board tracking

Closes #176

@joelvdavies joelvdavies self-assigned this Jun 16, 2025
@joelvdavies joelvdavies added the enhancement New feature or request label Jun 16, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2025

Codecov Report

Attention: Patch coverage is 96.42857% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.17%. Comparing base (ff963a7) to head (a9ccb21).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
object_storage_api/core/exceptions.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #177      +/-   ##
===========================================
- Coverage    79.47%   78.17%   -1.31%     
===========================================
  Files           26       26              
  Lines          765      724      -41     
===========================================
- Hits           608      566      -42     
- Misses         157      158       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joelvdavies joelvdavies force-pushed the refactor-error-handling-#176 branch from b7e0f1e to a9ccb21 Compare June 18, 2025 13:11
@joelvdavies joelvdavies requested a review from VKTB June 25, 2025 11:02
@joelvdavies joelvdavies marked this pull request as ready for review June 25, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve error handling?

3 participants