Skip to content

Conversation

louise-davies
Copy link
Member

Description

Major version because there's a couple of breaking changes that required changes to plugins & the Vite migration is on here which although doesn't change the result code compatibility is a large change in and of itself

joelvdavies and others added 30 commits March 12, 2024 15:26
louise-davies and others added 22 commits September 19, 2025 16:07
…-action-digest

Update codecov/codecov-action digest to 5a10915
…esting-library-7.x

Update dependency eslint-plugin-testing-library to v7.10.0
…esting-library-7.x

Update dependency eslint-plugin-testing-library to v7.11.0
…ckfile

Update dependency globals to v16.4.0
…-monorepo

Update dependency @testing-library/jest-dom to v6.9.1
Copy link
Contributor

@joelvdavies joelvdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tried this with ral-facilities/datagateway#1809, and found an issue using the "icat" auth provider. Its still trying to contact the oidc_providers endpoint and giving

Image

when going to the login page.

@louise-davies
Copy link
Member Author

@joelvdavies are you pointing at datagateway-dseg? I haven't updated the scigateway-auth code there yet. The correct behaviour of the icat authenticator is to try and query for potential OIDC providers

@joelvdavies
Copy link
Contributor

@joelvdavies are you pointing at datagateway-dseg? I haven't updated the scigateway-auth code there yet. The correct behaviour of the icat authenticator is to try and query for potential OIDC providers

Yep as discussed I was which is why it was happening.

Copy link
Contributor

@joelvdavies joelvdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, working well with IMS.

@louise-davies louise-davies merged commit da4f072 into main Oct 8, 2025
2 checks passed
@louise-davies louise-davies deleted the release/v4.0.0 branch October 8, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants