Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement item retract + notification #17

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

implement item retract + notification #17

wants to merge 4 commits into from

Conversation

souliane
Copy link
Contributor

needs the changes from #13 to work (or change in wokkel/pubsub.py line 986 to directly use PubSubRequest)

@ralphm
Copy link
Owner

ralphm commented Oct 4, 2016

Thanks for this contribution! A few comments:

  • notifyRetract lacks a docstring in wokkel.iwokkel.IPubSubService (which would then be inherited in the docstring for PubSubService automatically when generating API docs.
  • notifyRetract lacks tests. I think these could be more or less a copy of the tests for notifyPublish.

I removed the dependence on #13 (which I am still looking into), merged trunk to make Travis-CI happy, and pushed by version of the branch as item-retract.

@souliane
Copy link
Contributor Author

souliane commented Oct 5, 2016

Hi Ralph, thanks for the review. I merged your branch in mine and pushed souliane@cd63436

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@souliane @ralphm