Skip to content

Feature: Login #2254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dhruvan2006 wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Feature: Login #2254

dhruvan2006 wants to merge 1 commit into from

Conversation

@dhruvan2006
Copy link
Contributor

@dhruvan2006 dhruvan2006 commented Feb 1, 2025

New Auth class that allows for login functionality by settings cookies.

import yfinance as yf

auth = yf.Auth()
auth.set_login_cookies(os.getenv("COOKIE_T"), os.getenv("COOKIE_Y"))
auth.check_login()
auth.user

Inspired by #2220

R5dan
R5dan suggested changes Feb 1, 2025
View reviewed changes
Copy link
Contributor

@R5dan R5dan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way to let the user just put in there username and password and send a request to yahoo to verify?

yfinance/data.py
else:
return False
except Exception as e:
print(f"Error confirming login: {e}")
Copy link
Contributor

@R5dan R5dan Feb 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to change this to logging

@ValueRaider
Copy link
Collaborator

ValueRaider commented Feb 1, 2025

Wait for me to review and merge #2216, might make more sense to combine with config.

@dhruvan2006 dhruvan2006 mentioned this pull request Mar 19, 2025
Open
@ValueRaider
Copy link
Collaborator

ValueRaider commented Apr 1, 2025 •
edited
Loading

I've merged in the start of a config here #2391.

Maybe check_login should be automatic. If check_login is expensive, remember that yfinance can store cookie persistently ...

@Ate329
Copy link

Ate329 commented May 8, 2025

any updates on this?

@dhruvan2006
Copy link
Contributor Author

dhruvan2006 commented May 8, 2025

Will fix today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@R5dan R5dan R5dan requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dhruvan2006 @ValueRaider @Ate329 @R5dan