Skip to content

fix timezone convert bug in utils._parse_user_dt #2574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
skyblue6688 wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix timezone convert bug in utils._parse_user_dt #2574

skyblue6688 wants to merge 1 commit into from

Conversation

@skyblue6688
Copy link
Contributor

@skyblue6688 skyblue6688 commented Aug 2, 2025

This PR fixes the bug in: #2572

A unit test is added to check the correctness of the function.

Result of the unit test:

python3 -m unittest tests.test_utils

----------------------------------------------------------------------
Ran 20 tests in 0.014s

OK (expected failures=1)

@ValueRaider
Copy link
Collaborator

ValueRaider commented Aug 3, 2025

Can you rebase to dev branch? https://github.com/ranaroussi/yfinance/blob/main/CONTRIBUTING.md

@skyblue6688 skyblue6688 changed the base branch from main to dev August 3, 2025 17:57
@skyblue6688
Copy link
Contributor Author

skyblue6688 commented Aug 3, 2025

@ValueRaider Thanks for the guidance, it's now rebased on top of dev branch :)

@skyblue6688 skyblue6688 mentioned this pull request Aug 3, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@skyblue6688 @ValueRaider