Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for helm extraFlags when installing Rancher #67

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

thehejik
Copy link
Contributor

@thehejik thehejik commented Nov 13, 2024

  • Adds support for optional extraFlags array when installing Rancher
  • It is backward compatible so when extraFlags are omitted it will work as before

Can be used like this:

extraFlags := []string{
	"--set", "extraEnv[2].name=CATTLE_SKIP_HOSTED_CLUSTER_CHART_INSTALLATION",
	"--set-string", "extraEnv[2].value=true",
}

err := rancher.DeployRancherManager("my.awesome.domain", "latest", "devel", "2.9", "", "", extraFlags)
Expect(err).To(Not(HaveOccurred()))

https://go.dev/play/p/J8yUKpV-k6P

Copy link
Contributor

@sbulage sbulage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@juadk juadk merged commit 0d5b41c into rancher-sandbox:main Nov 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants