Skip to content

Include schema info on the diagnostic view and download #13983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2025

Conversation

nwmac
Copy link
Member

@nwmac nwmac commented Apr 3, 2025

Summary

Fixes #11231

Occurred changes and/or fixed issues

This PR updates the diagnostic page to fetch schema info for the clusters in addition to counts.

It then includes that in the report on screen and the download json.

Areas or cases that should be tested

Test the diagnostic page renders and that the download still works.

Screenshot/Video

Diagnostic page now shows schema count for each cluster and shows the custom schemas for a given cluster:

image

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@rancher-ui-project-bot rancher-ui-project-bot bot added this to the v2.12.0 milestone Apr 3, 2025
@nwmac nwmac requested a review from aalves08 April 4, 2025 07:59
Copy link
Member

@aalves08 aalves08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave it a test and works just fine. Could generate the response times and download the json. LGTM!

@nwmac nwmac merged commit 7670114 into rancher:master Apr 4, 2025
35 checks passed
@nwmac nwmac deleted the diagnostics-add-schema-counts branch April 4, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include schema counts in diagnostic data
2 participants