Automatically retry busy errors when creating write transactions #945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aruiz14
force-pushed
the
retry-withTransaction-on-busy-errors
branch
from
0f5adc0 to
83df783
Compare
aruiz14
force-pushed
the
retry-withTransaction-on-busy-errors
branch
from
83df783 to
81d72c7
Compare
4 tasks
|
|
||
| informerObjectCachePerms fs.FileMode = 0o600 | ||
|
|
||
| maxBeginTXAttemptsOnBusyErrors = 3 |
Contributor
There was a problem hiding this comment.
Should we expose this value via config?
Contributor
Author
There was a problem hiding this comment.
Hmm I have mixed feelings, it's probably something we will never need to tweak.
The error we are trying to mitigate is very specific and unlikely to happen, but still possible, and the only way to deal with it is to retry.
If it happens more than 3 times in a row it may be a sign of a bigger problem and we may not want to allow to ignore that?
ericpromislow
approved these changes
Dec 16, 2025
Contributor
ericpromislow
left a comment
ericpromislow
left a comment
There was a problem hiding this comment.
Looks fine with the suggestion
aruiz14
force-pushed
the
retry-withTransaction-on-busy-errors
branch
from
81d72c7 to
8bdc4b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: rancher/rancher#52872
Detect
SQLITE_BUSYandSQLITE_BUSY_SNAPSHOTwhich can happen normally on a concurrent system using WAL mode. Retry them automatically, since that specific case won't be managed by the busy handler.Note:
BeginTxreturns a*sql.Txwhich does not expose any public field, so I have to introduce a new interface in order to be able to mock it for my unit tests. Other kind of testing would be challenging since this patch is meant to mitigate a possible race condition.