Move the mcio=>pcio integration tests into yaml framework. #970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are the African country/capital objects with allocatable metric fields.
tomleb
reviewed
Jan 8, 2026
Comment on lines
+63
to
+86
| # filter on original cpu | ||
| - query: filter=status.allocatable.cpu=7000m | ||
| expected: | ||
| - default/rwanda # 7000m | ||
|
|
||
| # filter on processed cpu | ||
| - query: filter=status.allocatable.cpuRaw=14.25 | ||
| expected: | ||
| - default/angola # 14250m | ||
|
|
||
| # filter on original memory | ||
| - query: filter=status.allocatable.memory=12Mi | ||
| expected: | ||
| - default/botswana # 12Mi | ||
|
|
||
| # filter on processed memory | ||
| - query: filter=status.allocatable.memoryRaw=4194304 | ||
| expected: | ||
| - default/burundi # 4Mi | ||
|
|
||
| # filter on pods | ||
| - query: filter=status.allocatable.pods=20 | ||
| expected: | ||
| - default/mali |
Contributor
There was a problem hiding this comment.
With the test framework we ended up splitting sorting and filtering tests. Sorting test would test the order while filtering test would test the existence in the result. Though in both tests we allow pretty much any kind of query.
Should we split this test as well or keep it local to what we're testing 🤔
| - default/burundi | ||
| - default/mali | ||
| - default/rwanda | ||
| - query: sort=status.clusterName,metadata.name |
Contributor
There was a problem hiding this comment.
Curious to know why this needed to be removed since this PR doesn't contain any code changes. Was this flaky on your side?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the African country/capital objects with allocatable metric fields.