Expose topology-categories label in vSphere CSI chart #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pratikjagrut
changed the title
brandond
previously approved these changes
Apr 8, 2025
jiaqiluo
requested changes
Apr 8, 2025
There was a problem hiding this comment.
Can you bump the chart appVersion and version to 3.3.1-rancher10 at at https://github.com/rancher/vsphere-charts/blob/main/charts/rancher-vsphere-csi/Chart.yaml#L24 ?
pratikjagrut
force-pushed
the
expose.vsphere-categories
branch
from
e6b001e to
90e2ce1
Compare
Done. |
jiaqiluo
requested changes
Apr 15, 2025
pratikjagrut
force-pushed
the
expose.vsphere-categories
branch
from
90e2ce1 to
05f405a
Compare
pratikjagrut
force-pushed
the
expose.vsphere-categories
branch
from
05f405a to
91a5bf6
Compare
jiaqiluo
approved these changes
Jul 15, 2025
brandond
approved these changes
Jul 15, 2025
|
Hi @brandond, can you merge the PR? I'm not authorised. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Types of Change
Update the Rancher vSphere CSI Helm chart to expose the vsphere-categories labels configuration as configurable options in values.yaml and questions.yaml. This will allow users to enable and configure topology labels directly via Helm values or Rancher's UI without manual edits.
Linked Issues
#106
Additional Notes
After the PR is merged
Once the PR is merged, typically upon a new release, the necessary teams will be notified via Slack hook to perform the RKE2 Charts and RKE2 changes. Any developer working on this issue is not responsible for updating RKE2 Charts or RKE2.