Add configEnabled values to toggle CM creation #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-demicev
force-pushed
the
configmapvalue
branch
from
7bc48e6 to
98b93e3
Compare
snasovich
previously approved these changes
Apr 9, 2025
There was a problem hiding this comment.
The change looks straightforward enough and upgrade scenarios should be handled OK as well since configEnabled will not be passed explicitly (as it didn't exist on previous versions of the chart) and will then get is default true value (unless explicitly set to false).
Given limited usage of this field, especially in Rancher use cases, it's fine to not add it to questions.yaml.
brandond
requested changes
Apr 9, 2025
alexander-demicev
force-pushed
the
configmapvalue
branch
from
98b93e3 to
1d2e3a7
Compare
brandond
requested changes
Apr 10, 2025
alexander-demicev
force-pushed
the
configmapvalue
branch
2 times, most recently
from
c69e159 to
84576ae
Compare
brandond
requested changes
Apr 11, 2025
alexander-demicev
force-pushed
the
configmapvalue
branch
from
84576ae to
87a159f
Compare
brandond
requested changes
Apr 14, 2025
Signed-off-by: Alexandr Demicev <[email protected]>
alexander-demicev
force-pushed
the
configmapvalue
branch
from
87a159f to
1c57915
Compare
brandond
approved these changes
Apr 16, 2025
|
We don't do "releases" on this repo. |
Sorry if I was not clear. I was wondering where the chart is/will be published, including the changes in this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Types of Change
Add configEnabled values to toggle CM creation, this allows users to pass their own. The change is similar to upstream chart feature https://github.com/kubernetes/cloud-provider-vsphere/blob/master/charts/vsphere-cpi/templates/configmap.yaml#L7
Linked Issues
Additional Notes
After the PR is merged
Once the PR is merged, typically upon a new release, the necessary teams will be notified via Slack hook to perform the RKE2 Charts and RKE2 changes. Any developer working on this issue is not responsible for updating RKE2 Charts or RKE2.