Skip to content

Commit

Permalink
Small comment cleanups.
Browse files Browse the repository at this point in the history
  • Loading branch information
randall77 committed Oct 4, 2017
1 parent 23980e0 commit dbeef03
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
3 changes: 1 addition & 2 deletions gocore/object.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import (

// readObjects finds all the live objects in the heap and marks them
// in the p.heapInfo mark fields.
// It also fills in the p.sizes array.
func (p *Program) readObjects() {
ptrSize := p.proc.PtrSize()

Expand All @@ -28,7 +27,7 @@ func (p *Program) readObjects() {
i := x.Sub(p.arenaStart) / 512
h := &p.heapInfo[i]
if h.base == 0 { // not in a valid span
// TODO: probably a runtime/compiler error?
// Can happen with intra-stack pointers.
return
}
// Round down to object start.
Expand Down
1 change: 0 additions & 1 deletion main.go
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,6 @@ func main() {
c.ForEachReversePtr(y, func(x gocore.Object, r *gocore.Root, i, j int64) bool {
if r != nil {
// found it.
// TODO: print stack trace if root is a frame
if r.Frame == nil {
// Print global
fmt.Printf("%s", r.Name)
Expand Down

0 comments on commit dbeef03

Please sign in to comment.