feat: Add sample data validation testing infrastructure (Sprint 1) #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements Phase 1 of the comprehensive testing strategy to validate sample data consistency across all output formats and diff modes. Changes: - Create RoslynDiff.TestUtilities shared library project - TestResult model with Pass/Fail factory methods - SampleDataSourceAttribute for test case discovery - LineRange record for representing line number ranges - LineRangeComparer for overlap/duplicate detection - LineNumberValidator for comprehensive validation - Create RoslynDiff.TestUtilities.Tests project - 93 comprehensive unit tests (all passing) - LineRangeComparerTests (41 tests) - LineNumberValidatorTests (45 tests) - UsageExamplesTests (7 integration examples) - 3:1 test-to-code ratio - Setup test infrastructure - SampleValidation/ folder in Integration.Tests - TempTestCases/ for ad-hoc testing (.gitignored) - Project references and dependencies configured - Add comprehensive documentation - TestUtilities README with usage examples - XML documentation for all public APIs - Integration examples with RoslynDiff.Core models Test Results: 93/93 passed (100% pass rate) Build Status: All 9 projects compile successfully Ready for Sprint 2: Format parsers and validators Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Implements Phases 2-4 of the comprehensive testing strategy with parsers, validators, and orchestration for all roslyn-diff output formats. Sprint 2 Workstream D - Output Format Parsers: - JsonOutputParser (425 lines) - Parse JSON with System.Text.Json - HtmlOutputParser (378 lines) - Parse HTML with HtmlAgilityPack - TextOutputParser (305 lines) - Parse text with regex patterns - UnifiedDiffParser (307 lines) - Parse git-style unified diffs - TimestampNormalizer (223 lines) - Timestamp handling utilities - Shared models: ParsedChange, ParsedDiffResult - 13 unit tests for JSON parser (all passing) Sprint 2 Workstream E - Format Validators: - JsonValidator (270 lines) - Flag consistency, line integrity - HtmlValidator (398 lines) - Section integrity, data attributes - TextValidator (379 lines) - Line references, change indicators - GitDiffValidator (400 lines) - Unified diff format compliance - Full integration with parsers and Sprint 1 LineNumberValidator - Comprehensive error handling and detailed reporting Sprint 2 Workstream F - Core SampleDataValidator: - SampleDataValidator (567 lines) - Main orchestration class - ValidateAll() - Run all validations - ValidateLineNumberIntegrity() - Check line numbers - ValidateJsonConsistency() - JSON validation - ValidateHtmlConsistency() - HTML validation - ValidateCrossFormatConsistency() - Cross-format checks - SampleDataValidatorOptions (72 lines) - Configuration model - 11 integration tests (all passing) - 8 detailed usage examples - Complete documentation (ARCHITECTURE.md, IMPLEMENTATION_SUMMARY.md) Total Sprint 2 Code: - Production: ~4,389 lines - Tests: 24 tests (100% pass rate) - Files: 20 new files - Build: SUCCESS (0 warnings, 0 errors) Features: - Multi-format validation (JSON, HTML, Text, Git) - Line number integrity checks (overlaps, duplicates) - Cross-format consistency validation - CLI integration with timeout support - Automatic temp file cleanup with debug preservation - Comprehensive XML documentation throughout Ready for Sprint 3: Integration test classes and external tool comparison Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements Sprint 1 of the comprehensive testing strategy to validate sample data consistency across all output formats (JSON, HTML, Text, Git-style) and diff modes (Roslyn semantic, Line-by-line).
Related: Testing Strategy Document in
docs/testing-strategy-sample-validation.mdChanges
New Projects Created
RoslynDiff.TestUtilities - Shared test utility library
TestResultmodel with Pass/Fail factory methodsSampleDataSourceAttributefor test case discoveryLineRangerecord for line number rangesLineRangeComparerfor overlap/duplicate detectionLineNumberValidatorfor comprehensive validationRoslynDiff.TestUtilities.Tests - Unit tests for utilities
Test Infrastructure
SampleValidation/folder in Integration.Tests (ready for Sprint 2)TempTestCases/for ad-hoc testing (.gitignored)Documentation
Test Results
All existing tests continue to pass:
Build Status
✅ All 9 projects compile successfully (0 warnings, 0 errors)
Next Steps
Sprint 1 provides the foundation for Sprint 2:
🤖 Generated with Claude Code