Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to add OpenSpout\Common\Entity\Cell instances as data collection values #306

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow to add OpenSpout\Common\Entity\Cell instances as data collection values #306

wants to merge 2 commits into from

Commits on Feb 14, 2023

  1. Allow to add Cell instances as data collection values 

    Apply StyleCI patch

Fix  Codacy Static Code Analysis Issues

- The method exportOrDownload() has an NPath complexity of 300. The configured NPath comp1lexity threshold is 200.
- The method exportOrDownload() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10.
- Avoid using static access to class '\OpenSpout\Common\Entity\Row' in method 'writeHeader'.

Fix  test with 'ubuntu-latest, 8.1, lowest' build

Extract Cell and Row creations to single methods

Remove static Cell creation from Exportable trait

Eat this  Codacy Static Code Analyzer

Enough joking , Codacy
    @kusab85
    kusab85 committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    09d0381 View commit details
    Browse the repository at this point in the history

  2. Fix issue 310 test error

    @kusab85
    kusab85 committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    521d6da View commit details
    Browse the repository at this point in the history