Global stream pool #13922
Merged
Global stream pool #13922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eature/delta_binary
…eature/delta_binary
vuule
reviewed
Sep 7, 2023
| * @param count The number of `cuda_stream_view` objects to return. | ||
| * @return Vector containing `count` stream views. | ||
| */ | ||
| std::vector<rmm::cuda_stream_view> fork_streams(rmm::cuda_stream_view stream, std::size_t count); |
Contributor
There was a problem hiding this comment.
I'm not 100% sure, but can't think of a scenario where caller would not want to keep the streams.
Suggested change
| std::vector<rmm::cuda_stream_view> fork_streams(rmm::cuda_stream_view stream, std::size_t count); | |
| [[nodiscard]] std::vector<rmm::cuda_stream_view> fork_streams(rmm::cuda_stream_view stream, std::size_t count); |
bdice
approved these changes
Sep 8, 2023
PointKernel
reviewed
Sep 8, 2023
Co-authored-by: Yunsong Wang <[email protected]>
Member
|
/ok to test |
harrism
requested changes
Sep 12, 2023
Member
harrism
left a comment
harrism
left a comment
There was a problem hiding this comment.
Great work. Just one more missing const, I think.
| * @param count The number of stream views to return. | ||
| * @return Vector containing `count` stream views. | ||
| */ | ||
| std::vector<rmm::cuda_stream_view> fork_streams(rmm::cuda_stream_view stream, uint32_t count); |
Member
There was a problem hiding this comment.
Ultimately this will not be in the cudf namespace, but in rmm. I think there we should consider cudf::stream_view::fork(int num_streams) and cudf::stream_view::join(std::span<rmm::cuda_stream_view const> other_streams).
I'm OK with this for now.
Contributor
|
/ok to test |
harrism
approved these changes
Sep 12, 2023
Member
|
/merge |
Contributor
|
/ok to test |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#13637 added a static stream pool object for use by the Parquet reader. This PR expands upon that by:
cudf::detailnamespace.Checklist