Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always prefer device_reads when kvikio is enabled #17260

Draft
wants to merge 1 commit into
base: branch-24.12
Choose a base branch
from

Conversation

vuule
Copy link
Contributor

@vuule vuule commented Nov 6, 2024

Description

Issue #17259

Avoid checking _gds_read_preferred_threshold threshold when deciding whether device_read is preferred to host_read + H2D copy. The reasons are twofold:

  1. KvikIO already has an internal threshold for GDS use so we don't need to check on our end as well.
  2. Without actual GDS use, kvikIO uses a pinned bounce buffer to efficiently copy to the device.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Nov 6, 2024
@vuule vuule added cuIO cuIO issue Performance Performance related issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuIO cuIO issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Performance Performance related issue
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

1 participant