Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make constructor of DeviceMemoryBufferView and ContiguousTable public #17265

Open
wants to merge 1 commit into
base: branch-24.12
Choose a base branch
from
Open

Make constructor of DeviceMemoryBufferView and ContiguousTable public #17265

wants to merge 1 commit into from
+2 −2

Conversation

liurenjie1024
Copy link
Contributor

Description

Make constructor of DeviceMemoryBufferView and ContiguousTable public.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@liurenjie1024 liurenjie1024 requested a review from a team as a code owner November 7, 2024 09:27
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 7, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the Java Affects Java cuDF API. label Nov 7, 2024
@liurenjie1024 liurenjie1024 added 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Nov 7, 2024
@liurenjie1024 liurenjie1024 mentioned this pull request Nov 7, 2024
Open
@liurenjie1024
Copy link
Contributor Author

/ok to test

@liurenjie1024 liurenjie1024 added the improvement Improvement / enhancement to an existing function label Nov 7, 2024
jlowe
jlowe reviewed Nov 7, 2024
View reviewed changes
java/src/main/java/ai/rapids/cudf/ContiguousTable.java
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2024 copyrights

java/src/main/java/ai/rapids/cudf/DeviceMemoryBufferView.java
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2024 copyrights

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe jlowe left review comments

@revans2 revans2 Awaiting requested review from revans2

At least 1 approving review is required to merge this pull request.

Assignees

@liurenjie1024 liurenjie1024

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. non-breaking Non-breaking change
Projects
cuDF/Dask/Numba/UCX
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liurenjie1024 @jlowe