Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose stream-ordering in nvtext API #17446

Merged
merged 7 commits into from
Dec 4, 2024
Merged

Expose stream-ordering in nvtext API #17446

merged 7 commits into from
Dec 4, 2024

Conversation

shrshi
Copy link
Contributor

@shrshi shrshi commented Nov 26, 2024

Description

Adds stream parameter to

cudf::nvtext::byte_pair_encoding

Added stream gtests to verify correct stream forwarding.

Reference: #13744

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Nov 26, 2024
@shrshi shrshi added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 26, 2024
davidwendt
davidwendt requested changes Nov 26, 2024
View reviewed changes
cpp/tests/streams/text/bpe_test.cpp Outdated Show resolved Hide resolved
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 27, 2024

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@shrshi
Copy link
Contributor Author

shrshi commented Nov 27, 2024

/ok to test

@shrshi shrshi requested a review from davidwendt November 27, 2024 14:20
@shrshi shrshi marked this pull request as ready for review November 27, 2024 14:20
@shrshi shrshi requested a review from a team as a code owner November 27, 2024 14:20
@shrshi shrshi requested a review from PointKernel November 27, 2024 14:20
@shrshi shrshi added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Dec 2, 2024
@davidwendt
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 43fac3b into rapidsai:branch-25.02 Dec 4, 2024
105 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwendt davidwendt davidwendt approved these changes

@PointKernel PointKernel PointKernel approved these changes

Assignees

@shrshi shrshi

@davidwendt davidwendt

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shrshi @davidwendt @PointKernel