-
Notifications
You must be signed in to change notification settings - Fork 942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent pylibcudf
serialization in cudf-polars
#17449
Closed
pentschev
wants to merge
14
commits into
rapidsai:branch-25.04
from
pentschev:prevent-pylibcudf-serialization
Closed
Changes from 2 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
eb4a2ff
Reorder `Agg` to prevent need for `pylibcudf` serialization
pentschev 165e68c
Reorder `StringFunction` to prevent need for `pylibcudf` serialization
pentschev 99a5d12
Reorder `GroupBy` to prevent need for `pylibcudf` serialization
pentschev 3e14ec9
Implement picklable `BinOp` type
pentschev 2ba7ed1
Merge branch 'branch-25.02' into prevent-pylibcudf-serialization
pentschev 4eba56c
Merge remote-tracking branch 'upstream/branch-25.02' into prevent-pyl…
pentschev ef36d42
Revert "Implement picklable `BinOp` type"
pentschev 5635388
Merge remote-tracking branch 'origin/prevent-pylibcudf-serialization'…
pentschev bba8b3f
Merge remote-tracking branch 'upstream/branch-25.02' into prevent-pyl…
pentschev 2d37c08
Fix to avoid requiring serialization for `Agg`
pentschev 54a9cd6
Merge remote-tracking branch 'upstream/branch-25.02' into prevent-pyl…
pentschev faf42d0
Make `self.request` a property
pentschev 7183bc8
Merge remote-tracking branch 'upstream/branch-25.02' into prevent-pyl…
pentschev bfaf41e
Add `GroupbyOptions` wrapper
pentschev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eventually these will also need translated, but for now we can dodge it because they are always
None
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, I couldn't find any examples in our tests to aid that, so for now I left it as above to make things simpler.