Move unnecessary utilities from cudf._lib.scalar #17636
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Python
bdice
reviewed
Dec 20, 2024
python/cudf/cudf/utils/utils.py
Outdated
Comment on lines
345
to
352
| if is_na_like(slr): | ||
| return True | ||
| elif ( | ||
| isinstance(slr, (np.datetime64, np.timedelta64)) and np.isnat(slr) | ||
| ) or slr is pd.NaT: | ||
| return True | ||
| else: | ||
| return False |
There was a problem hiding this comment.
Try to combine this into something like:
return is_na_like(slr) or (isinstance(slr, (np.datetime64, np.timedelta64)) and np.isnat(slr) or slr is pd.NaTThere was a problem hiding this comment.
Or if you leave it the long way, maybe add comments that help explain the second case.
bdice
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In preparation for transitioning
DeviceScalarto pylibcudf'sScalar, moving_is_null_host_scalar(a pure Python function) tocudf.utils.utilsand removesas_device_scalarin favor of going throughcudf.ScalarChecklist