Avoid shallow copies in groupby methods #17646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Python
| @@ -3542,6 +3539,13 @@ def keys(self): | |||
| self._key_columns[0], name=self.names[0] | |||
| ) | |||
|
|
|||
| @property | |||
| def values_column_names(self) -> list[Hashable]: | |||
There was a problem hiding this comment.
Suggested change
| def values_column_names(self) -> list[Hashable]: | |
| def _values_column_names(self) -> list[Hashable]: |
Does pandas have this public property? If not, should we just make it a private property?
There was a problem hiding this comment.
It doesn't, so I can make this private
bdice
approved these changes
Jan 2, 2025
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Noticed while working on #17644 that
diffandfillnawere make some unnecessary shallow copies of thegrouping.valueobject. Also noticed that_cov_or_corrjust pulled the column names out ofgrouping.valueobject, so made a separate API,values_column_namesto just create the column names without pulling out the actual columns.Checklist