Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for pyarrow-19 #17794

Merged
merged 5 commits into from
Jan 25, 2025
Merged

Add support for pyarrow-19 #17794

merged 5 commits into from
Jan 25, 2025

Conversation

galipremsagar
Copy link
Contributor

Description

This PR upgrades the upper bound pinnings for pyarrow in cudf.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 23, 2025
@galipremsagar galipremsagar self-assigned this Jan 23, 2025
@galipremsagar galipremsagar requested a review from a team as a code owner January 23, 2025 17:22
@galipremsagar galipremsagar requested a review from bdice January 23, 2025 17:22
@github-actions github-actions bot added Python Affects Python cuDF API. pylibcudf Issues specific to the pylibcudf package labels Jan 23, 2025
bdice
bdice approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also #17422 which I believe contains equivalent changes but was blocked by some kind of Arrow failure.

@davidwendt davidwendt mentioned this pull request Jan 24, 2025
Merged
3 tasks
@galipremsagar galipremsagar requested a review from a team as a code owner January 24, 2025 15:21
bdice
bdice reviewed Jan 24, 2025
View reviewed changes
python/cudf/cudf/tests/test_parquet.py Outdated
@@ -4373,6 +4374,10 @@ def test_parquet_reader_mismatched_nullability_structs(tmpdir):
)


@pytest.mark.skipif(
platform.machine() == "aarch64",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also skip this only if the version is 19.0.0? We should make sure this fix gets into later releases.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup

@bdice
Copy link
Contributor

bdice commented Jan 25, 2025

I'm going to trigger a merge since this is needed for #17422.

@bdice
Copy link
Contributor

bdice commented Jan 25, 2025

/merge

@rapids-bot rapids-bot bot merged commit 922ca75 into rapidsai:branch-25.02 Jan 25, 2025
109 of 118 checks passed
@bdice
Copy link
Contributor

bdice commented Jan 25, 2025 •
edited
Loading

We missed updating conda recipes and CMakeLists.txt for libcudf tests here…

We’ll get those changes in #17422.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@wence- wence- Awaiting requested review from wence- wence- is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@Matt711 Matt711 Awaiting requested review from Matt711 Matt711 is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@galipremsagar @bdice