Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run Auto Assign PR workflow if PR is not merged #17888

Merged
merged 9 commits into from
Feb 5, 2025

Conversation

mroeschke
Copy link
Contributor

Description

It appears that currently the .github/workflows/auto-assign.yml workflow runs on every PR commit even when an assignee has already been set (e.g. https://github.com/rapidsai/cudf/actions/runs/13062684572/job/36449057944) and on merge on the current branch (e.g. https://github.com/rapidsai/cudf/actions/runs/13072179599/job/36476031430).

I think in theory we would only want to run this workflow once upon PR opening (?), but I added a condition to run this workflow if a PR does not have an assignee (name). cc @Matt711

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 31, 2025
@mroeschke mroeschke requested a review from a team as a code owner January 31, 2025 18:12
Copy link
Contributor

@Matt711 Matt711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you re-target to 25.04?

.github/workflows/auto-assign.yml Outdated Show resolved Hide resolved
@mroeschke mroeschke changed the base branch from branch-25.02 to branch-25.04 January 31, 2025 22:14
@vyasr vyasr requested a review from Matt711 February 3, 2025 23:52
@mroeschke mroeschke changed the title Only run Auto Assign PR workflow if PR does not have an assignee Only run Auto Assign PR workflow if PR is not merged Feb 4, 2025
@vyasr
Copy link
Contributor

vyasr commented Feb 4, 2025

/merge

@rapids-bot rapids-bot bot merged commit a5dddb0 into rapidsai:branch-25.04 Feb 5, 2025
113 checks passed
@mroeschke mroeschke deleted the gh/auto_asign/fix branch February 5, 2025 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants