Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new rapids-logger library #17899

Merged
merged 30 commits into from
Feb 11, 2025
Merged

Use new rapids-logger library #17899

merged 30 commits into from
Feb 11, 2025

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Feb 2, 2025

Description

Contributes to rapidsai/build-planning#104.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added improvement Improvement / enhancement to an existing function breaking Breaking change labels Feb 2, 2025
@vyasr vyasr self-assigned this Feb 2, 2025
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Feb 2, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API. CMake CMake build issue labels Feb 2, 2025
@vyasr
Copy link
Contributor Author

vyasr commented Feb 2, 2025

/ok to test

@vyasr vyasr force-pushed the feat/rapids_logger_library branch from 8095a12 to d359c37 Compare February 2, 2025 07:22
@vyasr
Copy link
Contributor Author

vyasr commented Feb 2, 2025

/ok to test

@vyasr vyasr force-pushed the feat/rapids_logger_library branch from d359c37 to c6cd7a2 Compare February 2, 2025 07:40
@vyasr
Copy link
Contributor Author

vyasr commented Feb 2, 2025

/ok to test

@vyasr
Copy link
Contributor Author

vyasr commented Feb 2, 2025

/ok to test

@vyasr
Copy link
Contributor Author

vyasr commented Feb 2, 2025

/ok to test

@vyasr
Copy link
Contributor Author

vyasr commented Feb 2, 2025

/ok to test

davidwendt
davidwendt previously requested changes Feb 5, 2025
View reviewed changes
cpp/include/cudf/logger.hpp Outdated Show resolved Hide resolved
@vyasr vyasr requested a review from davidwendt February 5, 2025 21:41
@vyasr vyasr requested a review from davidwendt February 5, 2025 22:47
@vyasr
Copy link
Contributor Author

vyasr commented Feb 6, 2025

I resolved the spark-rapids issue in rapidsai/rapids-cmake@ae4cb7f. I just kicked off an updated build of rmm based on that commit, then I'll rerun CI here for a final test and then we should be good to start merging up the chain.

The remaining spark-rapids-jni issue won't be fixed until the upstream PRs in rapids-cmake and rmm get merged.

bdice
bdice reviewed Feb 10, 2025
View reviewed changes
cpp/src/utilities/logger.cpp Outdated Show resolved Hide resolved
bdice
bdice approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, just one comment.

jameslamb
jameslamb approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, pending removing all the CI-specific stuff. Left a few small comments, do what you want with them, I don't need to re-review.

dependencies.yaml Outdated Show resolved Hide resolved
python/libcudf/libcudf/load.py Outdated Show resolved Hide resolved
This was referenced Feb 10, 2025
Merged
Merged
@jameslamb jameslamb mentioned this pull request Feb 10, 2025
Merged
@jameslamb jameslamb mentioned this pull request Feb 10, 2025
Open
@vyasr
Copy link
Contributor Author

vyasr commented Feb 11, 2025

The spark-rapids-jni job can't pass on here because we need to simultaneously bump the pins for rapids-cmake, rmm, and cudf to get that working. We'll just have to test this downstream. I can say that I did successfully build that project locally against the latest hashes and it passed, so that's a good sign.

@vyasr
Copy link
Contributor Author

vyasr commented Feb 11, 2025

/merge

@rapids-bot rapids-bot bot merged commit 1a891e6 into rapidsai:branch-25.04 Feb 11, 2025
111 of 112 checks passed
@vyasr vyasr deleted the feat/rapids_logger_library branch February 11, 2025 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@jameslamb jameslamb jameslamb approved these changes

@gforsyth gforsyth gforsyth approved these changes

@Matt711 Matt711 Matt711 approved these changes

@wence- wence- Awaiting requested review from wence- wence- is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@karthikeyann karthikeyann Awaiting requested review from karthikeyann karthikeyann is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@pmattione-nvidia pmattione-nvidia Awaiting requested review from pmattione-nvidia pmattione-nvidia is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@davidwendt davidwendt Awaiting requested review from davidwendt

Assignees

@vyasr vyasr

Labels
breaking Breaking change CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vyasr @gforsyth @bdice @jameslamb @Matt711 @davidwendt