-
Notifications
You must be signed in to change notification settings - Fork 1k
[polars-rapidsmpf] enable spill to pinned memory #21067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
TomAugspurger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only question was whether a boolean will be sufficient, or whether we might need to configure something about the pinned memory resource. But https://github.com/rapidsai/rapidsmpf/blob/331162c5d8eec65352a18596f3d89c2a925db5f0/cpp/include/rapidsmpf/memory/pinned_memory_resource.hpp#L82 mentions that things like a maximum size should be configured outside of the MR, so that shouldn't be needed.
Do we have any opinions on whether this should be the default? Or do we need to collect some benchmark results first?
Yeah, I think a boolean should suffice for now.
@pentschev did some runs that showed mixed results, which might be because we don’t reuse the |
python/cudf_polars/cudf_polars/experimental/benchmarks/utils.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Lawrence Mitchell <[email protected]>
|
/merge |
Add option: