Skip to content

Add remaining pandas PDSH queries #21108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Matt711 wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add remaining pandas PDSH queries #21108

Matt711 wants to merge 7 commits into from
+602 −13

Conversation

@Matt711
Copy link
Contributor

@Matt711 Matt711 commented Jan 21, 2026 •
edited
Loading

Description

Courtesy of cursor-agent. Still took a lot of back and forth, stopping the agent, etc. Started from this prompt. And then clean up at the ending (e.g. removing unnecessary casts).

I want to implement the remaining TPC-H queries (10 through 22) in python/cudf/cudf/pandas/_benchmarks/pdsh.py.

Examples:
- Use the polars implementations python/cudf_polars/cudf_polars/experimental/benchmarks/pdsh.py.
- Use the FireDucks pandas implementations at https://github.com/fireducks-dev/polars-tpch/tree/fireducks/queries/pandas.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@Matt711 Matt711 requested a review from a team as a code owner January 21, 2026 00:15
@Matt711 Matt711 added feature request New feature or request non-breaking Non-breaking change labels Jan 21, 2026
@github-actions github-actions bot added Python Affects Python cuDF API. cudf.pandas Issues specific to cudf.pandas labels Jan 21, 2026
@GPUtester GPUtester moved this to In Progress in cuDF Python Jan 21, 2026
galipremsagar
galipremsagar requested changes Jan 21, 2026
View reviewed changes
Copy link
Contributor

@galipremsagar galipremsagar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Matt711 In this PR itself, for existing queries can you switch all datetime scalars to np.datetime64 scalars as you have in the new queries?

xref: #21101 (comment)

@Matt711
Copy link
Contributor Author

Matt711 commented Jan 21, 2026 •
edited by galipremsagar
Loading

@Matt711 In this PR itself, for existing queries can you switch all datetime scalars to np.datetime64 scalars as you have in the new queries?

xref: #21101 (comment)

Yup, you mean np.datetime64 to datetime, right?

@galipremsagar
Copy link
Contributor

galipremsagar commented Jan 21, 2026

@Matt711 In this PR itself, for existing queries can you switch all datetime scalars to np.datetime64 scalars as you have in the new queries?
xref: #21101 (comment)

Yup, you mean np.datetime64 to datetime, right?

Nope, datetime to np.datetime64 for queries q1 to q9

@galipremsagar galipremsagar mentioned this pull request Jan 21, 2026
Closed
2 tasks
@Matt711 Matt711 mentioned this pull request Jan 21, 2026
Open
Matt711 and others added 2 commits January 21, 2026 14:17
@Matt711
Merge branch 'main' into fea/pandas/pdsh-queries
2bfca50
@Matt711 @claude
Replace np.datetime64 with datetime in PDSH benchmarks
5358e26 
Replace all instances of np.datetime64 with datetime from the
datetime standard library for consistency with other queries
in the file.

Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
@Matt711
Copy link
Contributor Author

Matt711 commented Jan 21, 2026

Nope, datetime to np.datetime64 for queries q1 to q9

Okay not sure why I didn't see fallback when I turned on raise for fallback.

Matt711 and others added 2 commits January 21, 2026 19:30
@Matt711 @claude
Use datetime64 for Q1-Q9, datetime for Q10+ in PDSH benchmarks
7f51c36 
- Q1-Q9: Use np.datetime64 for date literals
- Q10+: Use datetime from datetime standard library

This split allows Q1-Q9 to use numpy's datetime64 type while
Q10+ uses Python's native datetime type.

Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
@galipremsagar
Use only datetim64 in all queries
fe15b94
@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

@TomAugspurger TomAugspurger Awaiting requested review from TomAugspurger TomAugspurger is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

@Matt711 Matt711

Labels

5 - Ready to Merge Testing and reviews complete, ready to merge cudf.pandas Issues specific to cudf.pandas feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

cuDF Python
Status: In Progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEA] Add all PDSH queries for cudf.pandas

2 participants

@Matt711 @galipremsagar