Fix for DeviceMin and DeviceMax default device operators #21118
+5
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
3 - Ready for Review
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test |
davidwendt
commented
Jan 21, 2026
| val_index = j; | ||
| val = element; | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
The above work around is no longer needed with the change to DeviceMin/DeviceMax.
davidwendt
commented
Jan 21, 2026
| } | ||
| } | ||
| val = agg_op(element, val); | ||
| if (val.data() == element.data()) { val_index = j; } |
Contributor
Author
There was a problem hiding this comment.
Comparing data() pointers is faster especially when the strings do not match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the DeviceMin and DeviceMax default device operators to use
cudf::detail::minandcudf::detail::maxutilities instead ofnumeric::detail::minandnumeric::detail:maxsince DeviceMin and DeviceMax are used for non-numeric types like strings as well as numerics.This also better works around the 13.1 compiler bug where the
DeviceMin/numeric::detail::minreturned the incorrect result forcudf::string_viewarguments.Checklist