Update BC computation to address normalization edge conditions #5105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ake it easier to compare/debug, disabled python test again since nx release is not out
jnke2016
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
networkx/networkx#7949 implements an update to normalization that was originally described in #4941. We pushed an update in #4974 that addressed the specific examples that the user identified in the original cugraph issue. However, while @eriknw was exploring updates to networkx to address this, he identified a few more edge conditions that needed to be satisfied. This PR addresses those remaining edge conditions.
Note that the python tests comparing results to networkx are still disabled. These can't be re-enabled until networkx/networkx#7949 is included in a networkx release.
Closes #5006