Compile Optimizations - batch 3 #5119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hrust has fixed the issue
ChuckHastings
added
improvement
github-actions
bot
removed
improvement
ChuckHastings
added
improvement
jnke2016
approved these changes
Jun 13, 2025
seunghwak
reviewed
Jun 13, 2025
cpp/src/community/k_truss_impl.cuh
Outdated
| std::nullopt, | ||
| std::nullopt, | ||
| std::nullopt, | ||
| std::move(edge_properties), |
Contributor
There was a problem hiding this comment.
We have shuffle_ext_edges. Should we better create shuffle_int_edges as well instead of calling this detail space function in the application code?
Collaborator
Author
There was a problem hiding this comment.
Yes, I meant to do that. I'll update this in the next push.
Collaborator
Author
There was a problem hiding this comment.
Added shuffle_int_edges
cpp/src/detail/shuffle_wrappers.hpp
Outdated
| namespace cugraph { | ||
| namespace detail { | ||
|
|
||
| // TODO (in this PR): move this file to the src/detail directory |
Contributor
There was a problem hiding this comment.
We have already moves this file, so the first line of this TODO statement is no longer valid, right?
cpp/tests/prims/mg_per_v_pair_transform_dst_nbr_intersection.cu
Outdated
Show resolved
Hide resolved
cpp/tests/prims/mg_per_v_pair_transform_dst_nbr_weighted_intersection.cu
Outdated
Show resolved
Hide resolved
cpp/tests/structure/mg_has_edge_and_compute_multiplicity_test.cpp
Outdated
Show resolved
Hide resolved
…4' into variant_work_part4
seunghwak
reviewed
Jul 7, 2025
Contributor
seunghwak
left a comment
seunghwak
left a comment
There was a problem hiding this comment.
LGTM except for the bug (start=>end).
| if (edge_id_) tmp_edge_properties.push_back(std::move((*edge_id_)[0])); | ||
| if (edge_type_) tmp_edge_properties.push_back(std::move((*edge_type_)[0])); | ||
| if (edge_start_time_) tmp_edge_properties.push_back(std::move((*edge_start_time_)[0])); | ||
| if (edge_start_time_) tmp_edge_properties.push_back(std::move((*edge_start_time_)[0])); |
Fix erroneous assertion (closes rapidsai#5138). Authors: - Seunghwa Kang (https://github.com/seunghwak) - Chuck Hastings (https://github.com/ChuckHastings) Approvers: - Chuck Hastings (https://github.com/ChuckHastings) URL: rapidsai#5142
seunghwak
approved these changes
Jul 7, 2025
Collaborator
Author
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next round of compile optimizations. Big focus on shuffle operations.
Breaking since it deletes some deprecated functions.
Aggregate reduction in size of libcugraph.so (with first two batches): 9%