Skip to content

[DO NOT MERGE] Adding VRAM monitoring to cuML accelerated sklearn test suite #6604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
viclafargue wants to merge 11 commits into from
Closed

[DO NOT MERGE] Adding VRAM monitoring to cuML accelerated sklearn test suite #6604

viclafargue wants to merge 11 commits into from

Conversation

@viclafargue
Copy link
Contributor

@viclafargue viclafargue commented Apr 29, 2025

No description provided.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Apr 29, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions bot added the Cython / Python Cython or Python issue label Apr 29, 2025
csadorf
csadorf reviewed Apr 29, 2025
View reviewed changes
Copy link
Contributor

@csadorf csadorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering that we run tests in parallel, we should couple this with a rmm stats collection.

I'd recommend to place the monitoring logic in a vendored pytest plugin module and add RMM. I had previously implemented something like this in #6535 .

@viclafargue viclafargue changed the title Adding VRAM monitoring to cuML accelerated sklearn test suite [DO NOT MERGE] Adding VRAM monitoring to cuML accelerated sklearn test suite Apr 30, 2025
@viclafargue viclafargue marked this pull request as ready for review April 30, 2025 09:07
@viclafargue viclafargue requested a review from a team as a code owner April 30, 2025 09:07
@viclafargue viclafargue requested review from divyegala and jcrist April 30, 2025 09:07
@viclafargue
Copy link
Contributor Author

viclafargue commented Apr 30, 2025

/ok to test

@viclafargue viclafargue requested a review from a team as a code owner April 30, 2025 15:43
@viclafargue viclafargue requested a review from jameslamb April 30, 2025 15:43
@github-actions github-actions bot added the ci label Apr 30, 2025
@csadorf csadorf added the DO NOT MERGE Hold off on merging; see PR for details label Apr 30, 2025
@csadorf
Copy link
Contributor

csadorf commented Apr 30, 2025

@viclafargue Considering that this is an experimental branch, can we place the PR into draft mode?

@viclafargue
Copy link
Contributor Author

viclafargue commented Apr 30, 2025

I’ll revert it to draft mode. I might be mistaken, but I believe CI doesn’t run on draft pull requests.

@viclafargue viclafargue marked this pull request as draft April 30, 2025 16:49
@viclafargue viclafargue marked this pull request as ready for review April 30, 2025 16:57
@viclafargue
Copy link
Contributor Author

viclafargue commented Apr 30, 2025

/ok to test

@viclafargue viclafargue marked this pull request as draft April 30, 2025 16:58
@csadorf
Copy link
Contributor

csadorf commented Apr 30, 2025

I’ll revert it to draft mode. I might be mistaken, but I believe CI doesn’t run on draft pull requests.

You just have to add the "/ok to test" command.

@viclafargue
Copy link
Contributor Author

viclafargue commented May 2, 2025

/ok to test

@viclafargue
Copy link
Contributor Author

viclafargue commented May 2, 2025

/ok to test

@viclafargue
Copy link
Contributor Author

viclafargue commented May 5, 2025

/ok to test

@csadorf csadorf closed this May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@csadorf csadorf csadorf left review comments

@jcrist jcrist Awaiting requested review from jcrist jcrist is a code owner automatically assigned from rapidsai/cuml-python-codeowners

@divyegala divyegala Awaiting requested review from divyegala divyegala is a code owner automatically assigned from rapidsai/cuml-python-codeowners

@jameslamb jameslamb Awaiting requested review from jameslamb jameslamb is a code owner automatically assigned from rapidsai/ci-codeowners

Assignees

No one assigned

Labels

ci Cython / Python Cython or Python issue DO NOT MERGE Hold off on merging; see PR for details

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@viclafargue @csadorf