-
Notifications
You must be signed in to change notification settings - Fork 107
Fix update-version.sh to remove leading zeros. #1003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: branch-25.08
Are you sure you want to change the base?
Conversation
This commit fixes an error in how version strings are replaced in the C API header. Bumping the version to 25.08 causes the minor version to be written as "08" instead of "8", producing an invalid octal number. This commit fixes the error in the script, and also bumps the versions in the C API, documentation, and workflow yamls.
That the |
static const uint16_t CUVS_VERSION_MAJOR = 25; | ||
static const uint16_t CUVS_VERSION_MINOR = 06; | ||
static const uint16_t CUVS_VERSION_PATCH = 00; | ||
static const uint16_t CUVS_VERSION_MINOR = 8; | ||
static const uint16_t CUVS_VERSION_PATCH = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than hard-coding these numbers in a C header, please consider generating them at CMake configure time with configure_file()
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I haven't grokked your suggestion properly.
When update-version.sh
is run, we would like for version-strings across all artifacts to be changed. For instance, update-version.sh 25.10
should cause the C API to return 25
, 8
, 0
as appropriate.
Should update-version.sh
now change our CMake files, instead of directly changing c_api.h
?
I think the |
(I'll fix the copyright dates shortly.) |
Not directly. It seems to update the
I've gotten an idea of how @KyleFromNVIDIA would prefer this were fixed. I'll try incorporate that change ASAP. |
This commit fixes an error in how version strings are replaced in the C API header.
Bumping the version to 25.08 causes the minor version to be written as "08" instead of "8", producing an invalid octal number.
This commit fixes the error in the script, and also bumps the versions in the C API, documentation, and workflow yamls.