Skip to content

Expose extend() in C API #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 112 commits into from
Jan 31, 2025
Merged

Conversation

ajit283
Copy link
Contributor

@ajit283 ajit283 commented Aug 6, 2024

Add functionality to add additional vectors after build to C API

@ajit283 ajit283 requested a review from a team as a code owner August 6, 2024 15:18
@lowener
Copy link
Contributor

lowener commented Jan 8, 2025

/ok to test

@cjnolet
Copy link
Member

cjnolet commented Jan 10, 2025

Looks like we have a couple test failures for the C extend() API of CAGRA

@cjnolet
Copy link
Member

cjnolet commented Jan 15, 2025

/ok to test

@cjnolet
Copy link
Member

cjnolet commented Jan 23, 2025

/ok to test

@cjnolet
Copy link
Member

cjnolet commented Jan 24, 2025

/ok to test

@cjnolet
Copy link
Member

cjnolet commented Jan 29, 2025

/ok to test

@github-actions github-actions bot added the CMake label Jan 31, 2025
@cjnolet
Copy link
Member

cjnolet commented Jan 31, 2025

/ok to test

@github-actions github-actions bot removed the CMake label Jan 31, 2025
Copy link
Member

@benfred benfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! just a minor issue with the c docstrings that I think should get fixed up - but aside from that I think this is good to go

@benfred
Copy link
Member

benfred commented Jan 31, 2025

/ok to test

@cjnolet
Copy link
Member

cjnolet commented Jan 31, 2025

/merge

@benfred benfred changed the title [WIP] Expose extend() in C API Expose extend() in C API Jan 31, 2025
@rapids-bot rapids-bot bot merged commit e6e0926 into rapidsai:branch-25.02 Jan 31, 2025
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpp improvement Improves an existing functionality non-breaking Introduces a non-breaking change Python
Development

Successfully merging this pull request may close these issues.

5 participants