Expose NN-Descent to C and Python #635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benfred
added
improvement
tfeher
requested changes
Feb 3, 2025
tfeher
approved these changes
Feb 4, 2025
cjnolet
reviewed
Feb 4, 2025
cpp/src/neighbors/nn_descent_c.cpp
Outdated
| extern "C" cuvsError_t cuvsNNDescentIndexParamsCreate(cuvsNNDescentIndexParams_t* params) | ||
| { | ||
| return cuvs::core::translate_exceptions([=] { | ||
| *params = new cuvsNNDescentIndexParams{.metric = L2Expanded, |
There was a problem hiding this comment.
If we're going to duplicate the params structs for now, can we at least use constants to specify the defaults? I can see a lot of confusion and long debugging sessions happening as a result of these not getting synchronized between the C++ and C APIs.
There was a problem hiding this comment.
how about we have the canonical defaults in the c++ struct - and then pull out of there ? Something like : 19deed9
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.