Add build_type input field for test.yaml #661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gforsyth
added
improvement
19 tasks
jameslamb
approved these changes
Feb 5, 2025
Member
jameslamb
left a comment
jameslamb
left a comment
There was a problem hiding this comment.
Can you change the title to "Add build_type input field for test.yaml" to match the other PRs from this issue?
That PR title will become a commit message when this is squash-merged.
Contributor
Author
Done! Not sure how that happened -- must've hit something weird on the command line. Thanks for catching it! |
cjnolet
approved these changes
Feb 5, 2025
Member
|
No prob! Seeing that + all the extraneous codeowners groups, I'm guessing that maybe this was originally targeted at |
Contributor
Author
|
/merge |
divyegala
pushed a commit
to divyegala/cuvs
that referenced
this pull request
Feb 12, 2025
Exposes `build_type` as an input in `test.yaml` so that `test.yaml` can be manually run against a specific branch/commit as needed. The default value is still `nightly`, and without maintainer intervention, that is what will run each night. xref rapidsai/build-planning#147 Authors: - Gil Forsyth (https://github.com/gforsyth) Approvers: - James Lamb (https://github.com/jameslamb) - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai#661
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes
build_typeas an input intest.yamlso thattest.yamlcan bemanually run against a specific branch/commit as needed.
The default value is still
nightly, and without maintainer intervention, thatis what will run each night.
xref rapidsai/build-planning#147