Skip to content

[FEA] Build Single Linkage API #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 57 commits into
base: branch-25.08
Choose a base branch
from
Open

[FEA] Build Single Linkage API #820

wants to merge 57 commits into from

Conversation

tarang-jain
Copy link
Contributor

@tarang-jain tarang-jain commented Apr 12, 2025 •
edited
Loading

  • Expose functions for building the dendrogram on the mutual reachability graph

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Apr 12, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@tarang-jain tarang-jain self-assigned this Apr 12, 2025
@github-actions github-actions bot added the cpp label Apr 12, 2025
@tarang-jain tarang-jain added feature request New feature or request non-breaking Introduces a non-breaking change labels Apr 17, 2025
@tarang-jain tarang-jain marked this pull request as ready for review April 18, 2025 03:15
@tarang-jain tarang-jain requested a review from a team as a code owner April 18, 2025 03:15
@tarang-jain
Copy link
Contributor Author

/ok to test

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Apr 18, 2025

/ok to test

@tarang-jain, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

@tarang-jain
Copy link
Contributor Author

/ok to test 2738db7

@divyegala divyegala mentioned this pull request Apr 18, 2025
Open
5 tasks
@tarang-jain tarang-jain mentioned this pull request Apr 18, 2025
Open
@tarang-jain
Copy link
Contributor Author

Notes:
These functions have been migrated from HDBSCAN runner in cuML and exposed as a new public API, that is not tested directly here. Instead the full usage is tested end-to-end in HDBSCAN inside cuML. To veify correctness, the cuML PR (rapidsai/cuml#6560), that uses this, currently fetches cuVS from the branch of this cuVS PR and the CI status on that PR can be checked. Once this PR is merged, I will revert the CMake changes to find the correct cuvs version in rapidsai/cuml#6560

jinsolp
jinsolp reviewed Apr 19, 2025
View reviewed changes
Copy link
Contributor

@jinsolp jinsolp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR Tarang! LGTM, just a few small suggestions : )

@tarang-jain
Copy link
Contributor Author

/ok to test

jinsolp
jinsolp approved these changes Jun 4, 2025
View reviewed changes
Copy link
Contributor

@jinsolp jinsolp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a few minor suggestions!

@tarang-jain tarang-jain mentioned this pull request Jun 5, 2025
Open
@tarang-jain
Copy link
Contributor Author

/ok to test 1dd9039

@tarang-jain
Copy link
Contributor Author

/ok to test 5426b35

@tarang-jain
Copy link
Contributor Author

/ok to test 3b0737d

@tarang-jain
Copy link
Contributor Author

/ok to test 6afb096

divyegala
divyegala reviewed Jun 9, 2025
View reviewed changes
@tarang-jain
Copy link
Contributor Author

/ok to test b86b6bd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet left review comments

@divyegala divyegala divyegala approved these changes

@jinsolp jinsolp jinsolp approved these changes

Assignees

@tarang-jain tarang-jain

Labels
cpp feature request New feature or request non-breaking Introduces a non-breaking change
Projects
Vector Search, ML, & Data Mining Release Board
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tarang-jain @divyegala @cjnolet @jinsolp