-
Notifications
You must be signed in to change notification settings - Fork 107
Moving dice distance from raft to cuvs and support for half types #971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: branch-25.08
Are you sure you want to change the base?
Conversation
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
@aamijar I know this isn't your fault, but we're closely monitoring the cuVS binary size going forward and the pairwise distance APIs are by far the largest offender. Can you check the metrics logs that are produced in this PR to see how much this new distance affects the libcuvs binary size? |
Hi @cjnolet, sure where can I check the binary size/metrics for this pr? |
@aamijar See the conda C++ build logs for the build metrics reports: https://github.com/rapidsai/cuvs/actions/runs/15453622193/job/43501422197#step:14:31 The HTML report here (https://downloads.rapids.ai/ci/cuvs/pull-request/971/59cb596/cuda12_x86_64.compile_lib.html) shows some data for the new files:
So at least 7 MB just from the new files. There may be other changes that affect the binary size of existing objects too. Maybe
|
Thank you @bdice! It would be nice if there was a way to highlight in the html report which files are edited from the PR and the increase or decrease in binary size. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolves #966