Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comment about Mambaforge install #409

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

jakirkham
Copy link
Member

No description provided.

@jakirkham jakirkham requested a review from a team as a code owner October 21, 2024 22:05
@jakirkham jakirkham requested review from bdice and trxcllnt and removed request for a team October 21, 2024 22:05
@@ -23,7 +23,7 @@ wget --no-hsts -q -O /tmp/miniforge.sh \

echo "Installing Mambaforge...";

# Install miniconda
# Install Mambaforge
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to replace mambaforge with miniforge everywhere in this repo.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but I don't want to take that on in this PR. Please raise a new issue/PR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. We can merge as-is for now.

@bdice bdice merged commit a5bba51 into rapidsai:branch-24.12 Oct 21, 2024
31 checks passed
@jakirkham jakirkham deleted the fix_conda_install_comment branch October 22, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants