Set compiler versions in context #755
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify the logic necessary to handle compiler versions by folding it into the context.
jakirkham
added
improvement
jakirkham
commented
Jun 13, 2025
Comment on lines
+29
to
+31
| cat > variants.yaml << EOF | ||
| cuda_version: | ||
| - ${RAPIDS_CUDA_VERSION} |
There was a problem hiding this comment.
This writes out the common variant file content for all cases
Comment on lines
+33
to
+35
| if [[ "$(arch)" == "aarch64" ]]; then | ||
| cat >> variants.yaml << EOF | ||
| - 12.1 # The last version to not support cufile |
There was a problem hiding this comment.
Then the legacy CUDA ARM builds are appended to the file
This also makes it easier to drop this section of code when it no longer applies
Comment on lines
12
to
+14
| should_use_cufile: ${{ x86_64 or (aarch64 and cuda_version >= "12.2") }} | ||
| c_compiler_version: ${{ 13 if should_use_cufile else 12 }} | ||
| cxx_compiler_version: ${{ c_compiler_version }} |
There was a problem hiding this comment.
Instead of setting different compiler versions in the CUDA variant file, we just set them here in the context. Also this ties them to the relevant thing. Namely whether we can build with cuFile or not
We can see this works as intended with the CUDA 12.1 ARM build
│ │ │ cuda-version ┆ 12.1 ┆ h1d6eff3_3 ┆ conda-forge ┆ 20.56 KiB │
│ │ │ gcc_impl_linux-aarch64 ┆ 12.4.0 ┆ h628656a_2 ┆ conda-forge ┆ 56.19 MiB │
│ │ │ gcc_linux-aarch64 ┆ 12.4.0 ┆ heb3b579_10 ┆ conda-forge ┆ 31.88 KiB │
│ │ │ gxx_impl_linux-aarch64 ┆ 12.4.0 ┆ h0bf7a72_2 ┆ conda-forge ┆ 11.36 MiB │
│ │ │ gxx_linux-aarch64 ┆ 12.4.0 ┆ h3f57e68_10 ┆ conda-forge ┆ 30.23 KiB │
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the logic necessary to handle compiler versions by folding it into the context.