-
Notifications
You must be signed in to change notification settings - Fork 205
Fix COO symmetrization #2582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: branch-25.04
Are you sure you want to change the base?
Fix COO symmetrization #2582
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## branch-25.04 #2582 +/- ##
=============================================
Coverage 80.83% 80.83%
=============================================
Files 19 19
Lines 527 527
=============================================
Hits 426 426
Misses 101 101 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before this is merged, I’d like a comparison done and a small test put in place. This is an important operation on the UMAP side right now and I want to make sure this is actually improving the correctness. Even an MRE in a unit test would be helpful.
What's the status of this fix? Is this something we'll want to get in for 25.04 (and if so, does anyone have capacity to do the investigation Corey requested above)? |
Until someone can demonstrate (with an appropriate gtest) that this behavior is causing a problem, I would treat it as a relatively low priority. |
I will write some tests to check if it actually improves the COO symmetrization. |
No description provided.