Skip to content

Fix COO symmetrization #2582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: branch-25.04
Choose a base branch
from
Open

Conversation

viclafargue
Copy link
Contributor

No description provided.

@viclafargue viclafargue requested a review from a team as a code owner February 13, 2025 11:41
@github-actions github-actions bot added the cpp label Feb 13, 2025
@viclafargue viclafargue added bug Something isn't working non-breaking Non-breaking change labels Feb 13, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.83%. Comparing base (3c0abf7) to head (71fb5c7).

Additional details and impacted files
@@              Coverage Diff              @@
##           branch-25.04    #2582   +/-   ##
=============================================
  Coverage         80.83%   80.83%           
=============================================
  Files                19       19           
  Lines               527      527           
=============================================
  Hits                426      426           
  Misses              101      101           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before this is merged, I’d like a comparison done and a small test put in place. This is an important operation on the UMAP side right now and I want to make sure this is actually improving the correctness. Even an MRE in a unit test would be helpful.

@jcrist
Copy link
Member

jcrist commented Mar 11, 2025

What's the status of this fix? Is this something we'll want to get in for 25.04 (and if so, does anyone have capacity to do the investigation Corey requested above)?

@cjnolet
Copy link
Member

cjnolet commented Mar 12, 2025

Until someone can demonstrate (with an appropriate gtest) that this behavior is causing a problem, I would treat it as a relatively low priority.

@viclafargue
Copy link
Contributor Author

I will write some tests to check if it actually improves the COO symmetrization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cpp non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants